diff options
| author | Stephen Hemminger <shemminger@linux-foundation.org> | 2007-11-26 11:54:50 -0800 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-12-01 16:32:29 -0500 |
| commit | 799b21d2bddd43145130e509efb92339eabafef9 (patch) | |
| tree | 2a5ea59435d0b723e98d57b9dc01f919ece5b78b | |
| parent | d08b9bdf0264a8134677373f97641712062c603f (diff) | |
| download | linux-799b21d2bddd43145130e509efb92339eabafef9.tar.gz linux-799b21d2bddd43145130e509efb92339eabafef9.tar.bz2 linux-799b21d2bddd43145130e509efb92339eabafef9.zip | |
skge: retry on MAC shutdown
Make sure and retry when shutting down the MAC. This code is copied
from sk98lin driver.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| -rw-r--r-- | drivers/net/skge.c | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/drivers/net/skge.c b/drivers/net/skge.c index 82edf44b9e2a..b680cb08e9ce 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -1713,7 +1713,7 @@ static void genesis_stop(struct skge_port *skge) { struct skge_hw *hw = skge->hw; int port = skge->port; - u32 reg; + unsigned retries = 1000; genesis_reset(hw, port); @@ -1721,20 +1721,17 @@ static void genesis_stop(struct skge_port *skge) skge_write16(hw, B3_PA_CTRL, port == 0 ? PA_CLR_TO_TX1 : PA_CLR_TO_TX2); - /* - * If the transfer sticks at the MAC the STOP command will not - * terminate if we don't flush the XMAC's transmit FIFO ! - */ - xm_write32(hw, port, XM_MODE, - xm_read32(hw, port, XM_MODE)|XM_MD_FTF); - - /* Reset the MAC */ - skge_write16(hw, SK_REG(port, TX_MFF_CTRL1), MFF_SET_MAC_RST); + skge_write16(hw, SK_REG(port, TX_MFF_CTRL1), MFF_CLR_MAC_RST); + do { + skge_write16(hw, SK_REG(port, TX_MFF_CTRL1), MFF_SET_MAC_RST); + if (!(skge_read16(hw, SK_REG(port, TX_MFF_CTRL1)) & MFF_SET_MAC_RST)) + break; + } while (--retries > 0); /* For external PHYs there must be special handling */ if (hw->phy_type != SK_PHY_XMAC) { - reg = skge_read32(hw, B2_GP_IO); + u32 reg = skge_read32(hw, B2_GP_IO); if (port == 0) { reg |= GP_DIR_0; reg &= ~GP_IO_0; |