diff options
| author | Benoit Taine <benoit.taine@lip6.fr> | 2014-05-26 17:21:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-27 16:23:44 -0700 |
| commit | a328512d3cb9e7b5d998eeb2675216edf4407f77 (patch) | |
| tree | e53828c33a5b0835241401adc5c706f23bdee921 | |
| parent | a7683eb3af6df30e3a3f3666d834e9abba8f5c22 (diff) | |
| download | linux-a328512d3cb9e7b5d998eeb2675216edf4407f77.tar.gz linux-a328512d3cb9e7b5d998eeb2675216edf4407f77.tar.bz2 linux-a328512d3cb9e7b5d998eeb2675216edf4407f77.zip | |
USB: storage: ene_ub6250: Use kmemdup instead of kmalloc + memcpy
This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci
Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/storage/ene_ub6250.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c index 1bfc9a6cab5f..ef6efb55dc31 100644 --- a/drivers/usb/storage/ene_ub6250.c +++ b/drivers/usb/storage/ene_ub6250.c @@ -1928,11 +1928,10 @@ static int ene_load_bincode(struct us_data *us, unsigned char flag) usb_stor_dbg(us, "load firmware %s failed\n", fw_name); goto nofw; } - buf = kmalloc(sd_fw->size, GFP_KERNEL); + buf = kmemdup(sd_fw->data, sd_fw->size, GFP_KERNEL); if (buf == NULL) goto nofw; - memcpy(buf, sd_fw->data, sd_fw->size); memset(bcb, 0, sizeof(struct bulk_cb_wrap)); bcb->Signature = cpu_to_le32(US_BULK_CB_SIGN); bcb->DataTransferLength = sd_fw->size; |