diff options
| author | Jan Kara <jack@suse.cz> | 2014-10-21 14:07:33 +0200 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2014-11-03 16:07:35 -0800 |
| commit | 9bd27ae4aafc9bfee6c8791f7d801ea16cc5622b (patch) | |
| tree | e88cfd25c5552cf04b61930a803635220fcd64cb | |
| parent | d64948a4df9f5571b0efa81f71a59bc86d7056a7 (diff) | |
| download | linux-9bd27ae4aafc9bfee6c8791f7d801ea16cc5622b.tar.gz linux-9bd27ae4aafc9bfee6c8791f7d801ea16cc5622b.tar.bz2 linux-9bd27ae4aafc9bfee6c8791f7d801ea16cc5622b.zip | |
f2fs: avoid returning uninitialized value to userspace from f2fs_trim_fs()
If user specifies too low end sector for trimming, f2fs_trim_fs() will
use uninitialized value as a number of trimmed blocks and returns it to
userspace. Initialize number of trimmed blocks early to avoid the
problem.
Coverity-id: 1248809
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
| -rw-r--r-- | fs/f2fs/segment.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 2c1e60893ef2..6b0850487aa2 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1032,6 +1032,7 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range) range->len < sbi->blocksize) return -EINVAL; + cpc.trimmed = 0; if (end <= MAIN_BLKADDR(sbi)) goto out; @@ -1043,7 +1044,6 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range) cpc.trim_start = start_segno; cpc.trim_end = end_segno; cpc.trim_minlen = range->minlen >> sbi->log_blocksize; - cpc.trimmed = 0; /* do checkpoint to issue discard commands safely */ write_checkpoint(sbi, &cpc); |