summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes@sipsolutions.net>2009-07-02 15:46:41 +0200
committerJohn W. Linville <linville@tuxdriver.com>2009-07-07 12:55:28 -0400
commit2dce4c2b5f0b43bd25bf9ea6ded06b7f8a54c91f (patch)
treef9ded076fd61f5bd4ce93c995a4c9ab0dbf60742
parent76d8b64e536362e16e38ee1c279c965ebfe094cc (diff)
downloadlinux-2dce4c2b5f0b43bd25bf9ea6ded06b7f8a54c91f.tar.gz
linux-2dce4c2b5f0b43bd25bf9ea6ded06b7f8a54c91f.tar.bz2
linux-2dce4c2b5f0b43bd25bf9ea6ded06b7f8a54c91f.zip
cfg80211: fix refcount leak
The code in cfg80211's cfg80211_bss_update erroneously grabs a reference to the BSS, which means that it will never be freed. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Cc: stable@kernel.org [2.6.29, 2.6.30] Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--net/wireless/scan.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index e95b638b919f..f8e71b300001 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -366,7 +366,6 @@ cfg80211_bss_update(struct cfg80211_registered_device *dev,
found = rb_find_bss(dev, res);
if (found) {
- kref_get(&found->ref);
found->pub.beacon_interval = res->pub.beacon_interval;
found->pub.tsf = res->pub.tsf;
found->pub.signal = res->pub.signal;