summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Ellerman <mpe@ellerman.id.au>2017-05-29 20:26:07 +1000
committerMichael Ellerman <mpe@ellerman.id.au>2017-06-01 19:54:40 +1000
commit99acc9bede06bbb2662aafff51f5b9e529fa845e (patch)
tree4c8ee57d363423843dbe5d4ffd2057f711a8ebed
parenta2b05b7aa60e1e9b60faf01dfb1cca35638d1ab1 (diff)
downloadlinux-99acc9bede06bbb2662aafff51f5b9e529fa845e.tar.gz
linux-99acc9bede06bbb2662aafff51f5b9e529fa845e.tar.bz2
linux-99acc9bede06bbb2662aafff51f5b9e529fa845e.zip
powerpc/spufs: Fix coredump of SPU contexts
If a process dumps core while it has SPU contexts active then we have code to also dump information about the SPU contexts. Unfortunately it's been broken for 3 1/2 years, and we didn't notice. In commit 7b1f4020d0d1 ("spufs: get rid of dump_emit() wrappers") the nread variable was removed and rc used instead. That means when the loop exits successfully, rc has the number of bytes read, but it's then used as the return value for the function, which should return 0 on success. So fix it by setting rc = 0 before returning in the success case. Fixes: 7b1f4020d0d1 ("spufs: get rid of dump_emit() wrappers") Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Acked-by: Jeremy Kerr <jk@ozlabs.org> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
-rw-r--r--arch/powerpc/platforms/cell/spufs/coredump.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/arch/powerpc/platforms/cell/spufs/coredump.c
index e5a891ae80ee..84b7ac926ce6 100644
--- a/arch/powerpc/platforms/cell/spufs/coredump.c
+++ b/arch/powerpc/platforms/cell/spufs/coredump.c
@@ -175,6 +175,8 @@ static int spufs_arch_write_note(struct spu_context *ctx, int i,
skip = roundup(cprm->pos - total + sz, 4) - cprm->pos;
if (!dump_skip(cprm, skip))
goto Eio;
+
+ rc = 0;
out:
free_page((unsigned long)buf);
return rc;