summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexandru Gheorghiu <gheorghiuandru@gmail.com>2013-03-25 15:50:34 +0200
committerTakashi Iwai <tiwai@suse.de>2013-04-02 11:23:00 +0200
commitb8e63df919d75ef4ecafd66b5123a798b18cc0e7 (patch)
treed24a0f34045d1dec15a2f6bc4f43408b6587c38a
parent0d9ffc979f761c091a23020692b3502fa776eac0 (diff)
downloadlinux-b8e63df919d75ef4ecafd66b5123a798b18cc0e7.tar.gz
linux-b8e63df919d75ef4ecafd66b5123a798b18cc0e7.tar.bz2
linux-b8e63df919d75ef4ecafd66b5123a798b18cc0e7.zip
sound: oss: sb_common: Used kmemdup instead of kmalloc and memcpy
Used kmemdup instead of replicating it's behaviour with kmalloc followed by memcpy. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/oss/sb_common.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/oss/sb_common.c b/sound/oss/sb_common.c
index 7d42c5418d1b..851a1da46be1 100644
--- a/sound/oss/sb_common.c
+++ b/sound/oss/sb_common.c
@@ -626,13 +626,12 @@ int sb_dsp_detect(struct address_info *hw_config, int pci, int pciio, struct sb_
*/
- detected_devc = kmalloc(sizeof(sb_devc), GFP_KERNEL);
+ detected_devc = kmemdup(devc, sizeof(sb_devc), GFP_KERNEL);
if (detected_devc == NULL)
{
printk(KERN_ERR "sb: Can't allocate memory for device information\n");
return 0;
}
- memcpy(detected_devc, devc, sizeof(sb_devc));
MDB(printk(KERN_INFO "SB %d.%02d detected OK (%x)\n", devc->major, devc->minor, hw_config->io_base));
return 1;
}