diff options
| author | Xie XiuQi <xiexiuqi@huawei.com> | 2013-07-30 11:06:09 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2013-07-30 22:19:05 +0200 |
| commit | 46591962cb5bfd2bfb0baf42497119c816503598 (patch) | |
| tree | 68086c02d0921b98d149471daa18c6472d2bdf0d | |
| parent | 323f54ed0f3ce20e9946c961fc928ccdb80d9345 (diff) | |
| download | linux-46591962cb5bfd2bfb0baf42497119c816503598.tar.gz linux-46591962cb5bfd2bfb0baf42497119c816503598.tar.bz2 linux-46591962cb5bfd2bfb0baf42497119c816503598.zip | |
generic-ipi: Kill unnecessary variable - csd_flags
After commit 8969a5ede0f9e17da4b943712429aef2c9bcd82b
("generic-ipi: remove kmalloc()"), wait = 0 can be guaranteed,
and all callsites of generic_exec_single() do an unconditional
csd_lock() now.
So csd_flags is unnecessary now. Remove it.
Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Link: http://lkml.kernel.org/r/51F72DA1.7010401@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
| -rw-r--r-- | kernel/smp.c | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/kernel/smp.c b/kernel/smp.c index fe9f773d7114..7332697cd184 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -186,25 +186,13 @@ void generic_smp_call_function_single_interrupt(void) while (!list_empty(&list)) { struct call_single_data *csd; - unsigned int csd_flags; csd = list_entry(list.next, struct call_single_data, list); list_del(&csd->list); - /* - * 'csd' can be invalid after this call if flags == 0 - * (when called through generic_exec_single()), - * so save them away before making the call: - */ - csd_flags = csd->flags; - csd->func(csd->info); - /* - * Unlocked CSDs are valid through generic_exec_single(): - */ - if (csd_flags & CSD_FLAG_LOCK) - csd_unlock(csd); + csd_unlock(csd); } } |