summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-11-17 18:35:53 +0000
committerThomas Gleixner <tglx@linutronix.de>2017-11-23 20:03:58 +0100
commite9990d70e8a063a7b894c5cbb99f630a0f41200d (patch)
tree47b0be3822a7e6c402faa576a892163b70e8a509
parent0e54705b0e01dcaf3eb2a496bb66d5f05012056b (diff)
downloadlinux-e9990d70e8a063a7b894c5cbb99f630a0f41200d.tar.gz
linux-e9990d70e8a063a7b894c5cbb99f630a0f41200d.tar.bz2
linux-e9990d70e8a063a7b894c5cbb99f630a0f41200d.zip
irqchip/qcom: Fix u32 comparison with value less than zero
The comparison of u32 nregs being less than zero is never true since nregs is unsigned. Fix this by making nregs a signed integer. Fixes: f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: kernel-janitors@vger.kernel.org Cc: Jason Cooper <jason@lakedaemon.net> Link: https://lkml.kernel.org/r/20171117183553.2739-1-colin.king@canonical.com
-rw-r--r--drivers/irqchip/qcom-irq-combiner.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/qcom-irq-combiner.c b/drivers/irqchip/qcom-irq-combiner.c
index 6aa3ea479214..f31265937439 100644
--- a/drivers/irqchip/qcom-irq-combiner.c
+++ b/drivers/irqchip/qcom-irq-combiner.c
@@ -238,7 +238,7 @@ static int __init combiner_probe(struct platform_device *pdev)
{
struct combiner *combiner;
size_t alloc_sz;
- u32 nregs;
+ int nregs;
int err;
nregs = count_registers(pdev);