summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2015-01-12 16:23:37 +0200
committerRusty Russell <rusty@rustcorp.com.au>2015-01-21 16:28:46 +1030
commit011f0e7a6944855436fb29c7a7e6c3c89c95f8fb (patch)
tree20513dda94177be3306922cbfc10a9a9679223e9
parenta4379fd841cc1af60ef495b8e5598b1f7327ec0c (diff)
downloadlinux-011f0e7a6944855436fb29c7a7e6c3c89c95f8fb.tar.gz
linux-011f0e7a6944855436fb29c7a7e6c3c89c95f8fb.tar.bz2
linux-011f0e7a6944855436fb29c7a7e6c3c89c95f8fb.zip
virtio/console: verify device has config space
Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/console needs config space access so make it fail gracefully if not there. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-rw-r--r--drivers/char/virtio_console.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index de03df9dd7c9..26afb56a8073 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1986,6 +1986,12 @@ static int virtcons_probe(struct virtio_device *vdev)
bool multiport;
bool early = early_put_chars != NULL;
+ if (!vdev->config->get) {
+ dev_err(&vdev->dev, "%s failure: config access disabled\n",
+ __func__);
+ return -EINVAL;
+ }
+
/* Ensure to read early_put_chars now */
barrier();