diff options
| author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2015-11-20 10:46:49 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-11-20 08:46:50 -0700 |
| commit | 8aeea03195ee6e33fcb00039c414eabfc37a4eb8 (patch) | |
| tree | dfafeb55bdf6ddd18172578165a018966ae2b264 | |
| parent | 604e8c8da8854351496215d269c3fa93859e3fee (diff) | |
| download | linux-8aeea03195ee6e33fcb00039c414eabfc37a4eb8.tar.gz linux-8aeea03195ee6e33fcb00039c414eabfc37a4eb8.tar.bz2 linux-8aeea03195ee6e33fcb00039c414eabfc37a4eb8.zip | |
mtip32xx: use formatting capability of kthread_create_on_node
kthread_create_on_node takes format+args, so there's no need to do the
pretty-printing in advance. Moreover, "mtip_svc_thd_99" (including its
'\0') only just fits in 16 bytes, so if index could ever go above 99
we'd have a stack buffer overflow.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | drivers/block/mtip32xx/mtip32xx.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index a28a562f7b7f..3457ac8c03e2 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -3810,7 +3810,6 @@ static int mtip_block_initialize(struct driver_data *dd) sector_t capacity; unsigned int index = 0; struct kobject *kobj; - unsigned char thd_name[16]; if (dd->disk) goto skip_create_disk; /* hw init done, before rebuild */ @@ -3958,10 +3957,9 @@ skip_create_disk: } start_service_thread: - sprintf(thd_name, "mtip_svc_thd_%02d", index); dd->mtip_svc_handler = kthread_create_on_node(mtip_service_thread, - dd, dd->numa_node, "%s", - thd_name); + dd, dd->numa_node, + "mtip_svc_thd_%02d", index); if (IS_ERR(dd->mtip_svc_handler)) { dev_err(&dd->pdev->dev, "service thread failed to start\n"); |