diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2014-01-13 16:48:19 +0100 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2014-01-25 03:14:37 -0500 |
| commit | 1deb46e2562561255c34075825fd00f22a858bb3 (patch) | |
| tree | 1ddd569cd9f72f16ad1a7c63e247c5847e4f44c2 | |
| parent | ce08b62d18b3f97cd4e5a39bd5898872b9201875 (diff) | |
| download | linux-1deb46e2562561255c34075825fd00f22a858bb3.tar.gz linux-1deb46e2562561255c34075825fd00f22a858bb3.tar.bz2 linux-1deb46e2562561255c34075825fd00f22a858bb3.zip | |
fs: factor out common code in fget() and fget_raw()
Apart from FMODE_PATH check fget() and fget_raw() are identical,
shift the code into the new simple helper, __fget(fd, mask). Saves
160 bytes.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | fs/file.c | 25 |
1 files changed, 8 insertions, 17 deletions
diff --git a/fs/file.c b/fs/file.c index d34e59e51743..4ed58a32575e 100644 --- a/fs/file.c +++ b/fs/file.c @@ -637,16 +637,16 @@ void do_close_on_exec(struct files_struct *files) spin_unlock(&files->file_lock); } -struct file *fget(unsigned int fd) +static struct file *__fget(unsigned int fd, fmode_t mask) { - struct file *file; struct files_struct *files = current->files; + struct file *file; rcu_read_lock(); file = fcheck_files(files, fd); if (file) { /* File object ref couldn't be taken */ - if (file->f_mode & FMODE_PATH || + if ((file->f_mode & mask) || !atomic_long_inc_not_zero(&file->f_count)) file = NULL; } @@ -655,25 +655,16 @@ struct file *fget(unsigned int fd) return file; } +struct file *fget(unsigned int fd) +{ + return __fget(fd, FMODE_PATH); +} EXPORT_SYMBOL(fget); struct file *fget_raw(unsigned int fd) { - struct file *file; - struct files_struct *files = current->files; - - rcu_read_lock(); - file = fcheck_files(files, fd); - if (file) { - /* File object ref couldn't be taken */ - if (!atomic_long_inc_not_zero(&file->f_count)) - file = NULL; - } - rcu_read_unlock(); - - return file; + return __fget(fd, 0); } - EXPORT_SYMBOL(fget_raw); /* |