diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2017-08-09 11:35:21 -0500 |
|---|---|---|
| committer | Boris Brezillon <boris.brezillon@free-electrons.com> | 2017-08-23 16:49:23 +0200 |
| commit | 238709b22097a16839078530e0a10812dde86f16 (patch) | |
| tree | b61ade4fa96b159f17ccd63c62df025dd87536e5 | |
| parent | 2192a8ddc11ad7f243bed44eef4add8e37a658fe (diff) | |
| download | linux-238709b22097a16839078530e0a10812dde86f16.tar.gz linux-238709b22097a16839078530e0a10812dde86f16.tar.bz2 linux-238709b22097a16839078530e0a10812dde86f16.zip | |
mtd: nand: mtk: fix error return code in mtk_ecc_probe()
platform_get_irq() returns an error code, but the mtk_ecc driver
ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
| -rw-r--r-- | drivers/mtd/nand/mtk_ecc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c index 6c3a4aab0b48..7f3b065b6b8f 100644 --- a/drivers/mtd/nand/mtk_ecc.c +++ b/drivers/mtd/nand/mtk_ecc.c @@ -464,8 +464,8 @@ static int mtk_ecc_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(dev, "failed to get irq\n"); - return -EINVAL; + dev_err(dev, "failed to get irq: %d\n", irq); + return irq; } ret = dma_set_mask(dev, DMA_BIT_MASK(32)); |