summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>2016-06-23 10:22:01 +0530
committerDavid Teigland <teigland@redhat.com>2016-06-23 11:55:58 -0500
commit5c93f56f770e69c4cf2dbaebecd6bcca205949f9 (patch)
tree895b867b6fd3d05c9a72fd28c052423921f4521c
parent505ee5283c3d23220dfbf7630bfc4efdc391e743 (diff)
downloadlinux-5c93f56f770e69c4cf2dbaebecd6bcca205949f9.tar.gz
linux-5c93f56f770e69c4cf2dbaebecd6bcca205949f9.tar.bz2
linux-5c93f56f770e69c4cf2dbaebecd6bcca205949f9.zip
dlm: Use kmemdup instead of kmalloc and memcpy
Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup. The Coccinelle semantic patch used to make this change is as follows: @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: David Teigland <teigland@redhat.com>
-rw-r--r--fs/dlm/lowcomms.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 1ab012a27d9f..963016c8f3d1 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1279,10 +1279,9 @@ static void init_local(void)
if (dlm_our_addr(&sas, i))
break;
- addr = kmalloc(sizeof(*addr), GFP_NOFS);
+ addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS);
if (!addr)
break;
- memcpy(addr, &sas, sizeof(*addr));
dlm_local_addr[dlm_local_count++] = addr;
}
}