diff options
| author | Nikolay Borisov <n.borisov.lkml@gmail.com> | 2016-07-25 20:12:13 +0300 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2016-07-28 03:00:45 +0200 |
| commit | 6b1a9a6c54122dade800fd61e90d441e58de19eb (patch) | |
| tree | 6642fbd06e9e6ce3279a0e6223a988e7c2b8b1d3 | |
| parent | c8799fc4674fe5bb9b9391f9eac202250b8370e1 (diff) | |
| download | linux-6b1a9a6c54122dade800fd61e90d441e58de19eb.tar.gz linux-6b1a9a6c54122dade800fd61e90d441e58de19eb.tar.bz2 linux-6b1a9a6c54122dade800fd61e90d441e58de19eb.zip | |
ceph: Mark the file cache as unreclaimable
Ceph creates multiple caches with the SLAB_RECLAIMABLE flag set, so
that it can satisfy its internal needs. Inspecting the code shows that
most of the caches are indeed reclaimable since they are directly
related to the generic inode/dentry shrinkers. However, one of the
cache used to satisfy struct file is not reclaimable since its
entries are freed only when the last reference to the file is
dropped. If a heavily loaded node opens a lot of files it can
introduce non-trivial discrepancies between memory shown as reclaimable
and what is actually reclaimed when drop_caches is used.
Fix this by removing the reclaimable flag for the file's cache.
Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
Signed-off-by: Yan, Zheng <zyan@redhat.com>
| -rw-r--r-- | fs/ceph/super.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index 7736a931376e..e247f6f0feb7 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c @@ -686,8 +686,8 @@ static int __init init_caches(void) if (ceph_dentry_cachep == NULL) goto bad_dentry; - ceph_file_cachep = KMEM_CACHE(ceph_file_info, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); + if (ceph_file_cachep == NULL) goto bad_file; |