summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>2014-06-10 13:53:50 -0400
committerSteven Rostedt <rostedt@goodmis.org>2014-06-10 13:53:50 -0400
commitda9c3413a27be5ba6f996e90495c836dd30b8841 (patch)
treea320d4d4318c6a0b8a4646e46e15059d1336b8c6
parentf0b70cc48cc282cb326a4d71b3d1dda7d8fafd2a (diff)
downloadlinux-da9c3413a27be5ba6f996e90495c836dd30b8841.tar.gz
linux-da9c3413a27be5ba6f996e90495c836dd30b8841.tar.bz2
linux-da9c3413a27be5ba6f996e90495c836dd30b8841.zip
tracing: Fix check of ftrace_trace_arrays list_empty() check
The check that tests if ftrace_trace_arrays is empty in top_trace_array(), uses the .prev pointer: if (list_empty(ftrace_trace_arrays.prev)) instead of testing the variable itself: if (list_empty(&ftrace_trace_arrays)) Although it is technically correct, it is awkward and confusing. Use the proper method. Link: http://lkml.kernel.org/r/87oay1bas8.fsf@sejong.aot.lge.com Reported-by: Namhyung Kim <namhyung@gmail.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r--kernel/trace/trace.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 9e82551dd566..9258f5a815db 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -252,7 +252,7 @@ static inline struct trace_array *top_trace_array(void)
{
struct trace_array *tr;
- if (list_empty(ftrace_trace_arrays.prev))
+ if (list_empty(&ftrace_trace_arrays))
return NULL;
tr = list_entry(ftrace_trace_arrays.prev,