diff options
| author | Alan Cox <alan@redhat.com> | 2008-10-13 10:36:40 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-13 09:51:40 -0700 |
| commit | e6885107736a4dd23e7d3bc103fe6d043c63c4de (patch) | |
| tree | 77454a1a03bd0021945e3e6ef08b6f39ef8dbf14 | |
| parent | b70ac7718579b5cbf3bdd74fd01132d1c91596f4 (diff) | |
| download | linux-e6885107736a4dd23e7d3bc103fe6d043c63c4de.tar.gz linux-e6885107736a4dd23e7d3bc103fe6d043c63c4de.tar.bz2 linux-e6885107736a4dd23e7d3bc103fe6d043c63c4de.zip | |
tty: move tioclinux from a special case
Right now we have ifdefs and hooks in the core ioctl handler for TIOCLINUX
and then test if its a console. This is brain dead. Instead call the
tioclinux helper from the relevant driver ioctl methods.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/char/tty_io.c | 4 | ||||
| -rw-r--r-- | drivers/char/vt.c | 2 | ||||
| -rw-r--r-- | drivers/char/vt_ioctl.c | 2 |
3 files changed, 2 insertions, 6 deletions
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index e4dce8709541..2f05728920e7 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c @@ -3026,10 +3026,6 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg) return put_user(tty->ldisc.ops->num, (int __user *)p); case TIOCSETD: return tiocsetd(tty, p); -#ifdef CONFIG_VT - case TIOCLINUX: - return tioclinux(tty, arg); -#endif /* * Break handling */ diff --git a/drivers/char/vt.c b/drivers/char/vt.c index 60359c360912..05ca1c5dcb1c 100644 --- a/drivers/char/vt.c +++ b/drivers/char/vt.c @@ -2583,8 +2583,6 @@ int tioclinux(struct tty_struct *tty, unsigned long arg) int lines; int ret; - if (tty->driver->type != TTY_DRIVER_TYPE_CONSOLE) - return -EINVAL; if (current->signal->tty != tty && !capable(CAP_SYS_ADMIN)) return -EPERM; if (get_user(type, p)) diff --git a/drivers/char/vt_ioctl.c b/drivers/char/vt_ioctl.c index c904e9ad4a71..8944ce508e2f 100644 --- a/drivers/char/vt_ioctl.c +++ b/drivers/char/vt_ioctl.c @@ -395,6 +395,8 @@ int vt_ioctl(struct tty_struct *tty, struct file * file, kbd = kbd_table + console; switch (cmd) { + case TIOCLINUX: + return tioclinux(tty, arg); case KIOCSOUND: if (!perm) goto eperm; |