diff options
| author | Swen Schillig <swen@vnet.ibm.com> | 2008-10-01 12:42:24 +0200 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-10-03 12:11:56 -0500 |
| commit | 9fb3cd86e4870d54d71a80323e97c48df4de05bd (patch) | |
| tree | b03dfde59ef84770511a7cace937bed26c55adb6 | |
| parent | e4e9ba5d9313f362d2192fb7a2d35a3bfb714b1e (diff) | |
| download | linux-9fb3cd86e4870d54d71a80323e97c48df4de05bd.tar.gz linux-9fb3cd86e4870d54d71a80323e97c48df4de05bd.tar.bz2 linux-9fb3cd86e4870d54d71a80323e97c48df4de05bd.zip | |
[SCSI] zfcp: fix erp list usage without using locks
The zfcp_erp_thread was using the nolock version of the dbf function.
This resulted in a list access while other tasks could modifying the
list. The symptom was an erp thread running at 100% CPU and never
returning from the dbf function.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
| -rw-r--r-- | drivers/s390/scsi/zfcp_erp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c index 8c117416d5ad..4539530768a2 100644 --- a/drivers/s390/scsi/zfcp_erp.c +++ b/drivers/s390/scsi/zfcp_erp.c @@ -1395,9 +1395,9 @@ static int zfcp_erp_thread(void *data) zfcp_erp_wakeup(adapter); } - zfcp_rec_dbf_event_thread(4, adapter); + zfcp_rec_dbf_event_thread_lock(4, adapter); down_interruptible(&adapter->erp_ready_sem); - zfcp_rec_dbf_event_thread(5, adapter); + zfcp_rec_dbf_event_thread_lock(5, adapter); } atomic_clear_mask(ZFCP_STATUS_ADAPTER_ERP_THREAD_UP, &adapter->status); |