summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-01-09 15:44:50 +0300
committerDave Airlie <airlied@redhat.com>2012-01-09 12:49:21 +0000
commit55ba70c40661b61f98c4188c428f265009af1aa5 (patch)
tree69055d80f453910904969bc441f4d0d7e78b05d0
parentb5215ef1a877cd81a2558f3ddbcf784671a27588 (diff)
downloadlinux-55ba70c40661b61f98c4188c428f265009af1aa5.tar.gz
linux-55ba70c40661b61f98c4188c428f265009af1aa5.tar.bz2
linux-55ba70c40661b61f98c4188c428f265009af1aa5.zip
drm/radeon: use after free in radeon_vm_bo_add()
"bo_va" is dereferenced in the error message. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
-rw-r--r--drivers/gpu/drm/radeon/radeon_gart.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c
index 8597d2c016e6..a97baf5c114f 100644
--- a/drivers/gpu/drm/radeon/radeon_gart.c
+++ b/drivers/gpu/drm/radeon/radeon_gart.c
@@ -494,10 +494,10 @@ int radeon_vm_bo_add(struct radeon_device *rdev,
}
if (bo_va->soffset >= tmp->soffset && bo_va->soffset < tmp->eoffset) {
/* bo and tmp overlap, invalid offset */
- kfree(bo_va);
dev_err(rdev->dev, "bo %p va 0x%08X conflict with (bo %p 0x%08X 0x%08X)\n",
bo, (unsigned)bo_va->soffset, tmp->bo,
(unsigned)tmp->soffset, (unsigned)tmp->eoffset);
+ kfree(bo_va);
mutex_unlock(&vm->mutex);
return -EINVAL;
}