summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-09-23 20:47:22 -0700
committerDavid S. Miller <davem@davemloft.net>2008-09-23 20:47:22 -0700
commitd87798450a7635ab1bcc80271a13ce4a53b016a9 (patch)
treed60f6a09089f856073e9a02df92dbdf54c3b62fb
parente5d2304802a63304a54cff010209c4a717a2509f (diff)
downloadlinux-d87798450a7635ab1bcc80271a13ce4a53b016a9.tar.gz
linux-d87798450a7635ab1bcc80271a13ce4a53b016a9.tar.bz2
linux-d87798450a7635ab1bcc80271a13ce4a53b016a9.zip
aoe: Fix OOPS after SKB queue changes.
Reported by Thomas Graf. If we don't unlink the SKB from the queue when we send it out in aoenet_xmit(), dev_hard_start_xmit() will see skb->next as non-NULL and interpret this to mean the SKB is part of a GSO segment list. Add __skb_unlink() call to fix that. Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/block/aoe/aoenet.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
index 8fb26030eba8..9157d64270cb 100644
--- a/drivers/block/aoe/aoenet.c
+++ b/drivers/block/aoe/aoenet.c
@@ -99,8 +99,10 @@ aoenet_xmit(struct sk_buff_head *queue)
{
struct sk_buff *skb, *tmp;
- skb_queue_walk_safe(queue, skb, tmp)
+ skb_queue_walk_safe(queue, skb, tmp) {
+ __skb_unlink(skb, queue);
dev_queue_xmit(skb);
+ }
}
/*