diff options
| author | Richard Guy Briggs <rgb@redhat.com> | 2014-09-18 20:50:17 -0400 |
|---|---|---|
| committer | Paul Moore <pmoore@redhat.com> | 2014-09-22 15:50:08 -0400 |
| commit | e173fb2646a832b424c80904c306b816760ce477 (patch) | |
| tree | cdc52ba9f36956a8d2894d48d77ecc166cb20315 | |
| parent | cbe0d6e8794f1da6cac1ea3864d2cfaf0bf87c8e (diff) | |
| download | linux-e173fb2646a832b424c80904c306b816760ce477.tar.gz linux-e173fb2646a832b424c80904c306b816760ce477.tar.bz2 linux-e173fb2646a832b424c80904c306b816760ce477.zip | |
selinux: cleanup error reporting in selinux_nlmsg_perm()
Convert audit_log() call to WARN_ONCE().
Rename "type=" to nlmsg_type=" to avoid confusion with the audit record
type.
Added "protocol=" to help track down which protocol (NETLINK_AUDIT?) was used
within the netlink protocol family.
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
[Rewrote the patch subject line]
Signed-off-by: Paul Moore <pmoore@redhat.com>
| -rw-r--r-- | security/selinux/hooks.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 5eb512b7ac31..29e64d4ca099 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -4727,10 +4727,9 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb) err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm); if (err) { if (err == -EINVAL) { - audit_log(current->audit_context, GFP_KERNEL, AUDIT_SELINUX_ERR, - "SELinux: unrecognized netlink message" - " type=%hu for sclass=%hu\n", - nlh->nlmsg_type, sksec->sclass); + WARN_ONCE(1, "selinux_nlmsg_perm: unrecognized netlink message:" + " protocol=%hu nlmsg_type=%hu sclass=%hu\n", + sk->sk_protocol, nlh->nlmsg_type, sksec->sclass); if (!selinux_enforcing || security_get_allow_unknown()) err = 0; } |