diff options
| author | Jan Kara <jack@suse.cz> | 2009-06-17 16:26:23 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-06-18 13:03:45 -0700 |
| commit | e8ef7aaea79a899be4d7f50e829900c0ce15e52f (patch) | |
| tree | 1cc2370f081264e506d85e954110d363961e37bd | |
| parent | ce05b2a9db1d86635a906f14427deff97eeb6183 (diff) | |
| download | linux-e8ef7aaea79a899be4d7f50e829900c0ce15e52f.tar.gz linux-e8ef7aaea79a899be4d7f50e829900c0ce15e52f.tar.bz2 linux-e8ef7aaea79a899be4d7f50e829900c0ce15e52f.zip | |
ext3: fix chain verification in ext3_get_blocks()
Chain verification in ext3_get_blocks() has been hosed since it called
verify_chain(chain, NULL) which always returns success. As a result
readers could in theory race with truncate. On the other hand the race
probably cannot happen with the current locking scheme, since by the
time ext3_truncate() is called all the pages are already removed and
hence get_block() shouldn't be called on such pages...
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/ext3/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index b0248c6d5d4c..253c2cdc8d04 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c @@ -820,7 +820,7 @@ int ext3_get_blocks_handle(handle_t *handle, struct inode *inode, while (count < maxblocks && count <= blocks_to_boundary) { ext3_fsblk_t blk; - if (!verify_chain(chain, partial)) { + if (!verify_chain(chain, chain + depth - 1)) { /* * Indirect block might be removed by * truncate while we were reading it. |