diff options
| author | Sinclair Yeh <syeh@vmware.com> | 2016-04-21 11:29:31 -0700 |
|---|---|---|
| committer | Sinclair Yeh <syeh@vmware.com> | 2016-04-28 11:07:30 -0700 |
| commit | 7851496a32319237456919575e5f4ba62f74cc7d (patch) | |
| tree | 3115350947df1fcf593116917c7d9c4bbb0f8aa1 | |
| parent | e02e58843153ce80a9fe7588def89b2638d40e64 (diff) | |
| download | linux-7851496a32319237456919575e5f4ba62f74cc7d.tar.gz linux-7851496a32319237456919575e5f4ba62f74cc7d.tar.bz2 linux-7851496a32319237456919575e5f4ba62f74cc7d.zip | |
drm/vmwgfx: Fix order of operation
mode->hdisplay * (var->bits_per_pixel + 7) gets evaluated before
the division, potentially making the pitch larger than it should
be.
Since the original intention is to do a div-round-up, just use
the macro instead.
Signed-off-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
| -rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c index 3b1faf7862a5..679a4cb98ee3 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c @@ -573,9 +573,9 @@ static int vmw_fb_set_par(struct fb_info *info) mode = old_mode; old_mode = NULL; } else if (!vmw_kms_validate_mode_vram(vmw_priv, - mode->hdisplay * - (var->bits_per_pixel + 7) / 8, - mode->vdisplay)) { + mode->hdisplay * + DIV_ROUND_UP(var->bits_per_pixel, 8), + mode->vdisplay)) { drm_mode_destroy(vmw_priv->dev, mode); return -EINVAL; } |