diff options
| author | Niklas Cassel <niklas.cassel@axis.com> | 2015-01-22 14:16:34 +0100 |
|---|---|---|
| committer | Steve French <steve.french@primarydata.com> | 2015-01-26 19:38:26 -0600 |
| commit | 7a1ceba071709d11271ebd921310b5a18404dd33 (patch) | |
| tree | 15af02690777a0333af178c4e1df7510ec1f0c0f | |
| parent | ca7df8e0bb2a5ec79691de8a1a4c0e611fe04e60 (diff) | |
| download | linux-7a1ceba071709d11271ebd921310b5a18404dd33.tar.gz linux-7a1ceba071709d11271ebd921310b5a18404dd33.tar.bz2 linux-7a1ceba071709d11271ebd921310b5a18404dd33.zip | |
cifs: fix MUST SecurityFlags filtering
If CONFIG_CIFS_WEAK_PW_HASH is not set, CIFSSEC_MUST_LANMAN
and CIFSSEC_MUST_PLNTXT is defined as 0.
When setting new SecurityFlags without any MUST flags,
your flags would be overwritten with CIFSSEC_MUST_LANMAN (0).
Signed-off-by: Niklas Cassel <niklass@axis.com>
Signed-off-by: Steve French <steve.french@primarydata.com>
| -rw-r--r-- | fs/cifs/cifs_debug.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c index 9c56ef776407..7febcf2475c5 100644 --- a/fs/cifs/cifs_debug.c +++ b/fs/cifs/cifs_debug.c @@ -606,9 +606,11 @@ cifs_security_flags_handle_must_flags(unsigned int *flags) *flags = CIFSSEC_MUST_NTLMV2; else if ((*flags & CIFSSEC_MUST_NTLM) == CIFSSEC_MUST_NTLM) *flags = CIFSSEC_MUST_NTLM; - else if ((*flags & CIFSSEC_MUST_LANMAN) == CIFSSEC_MUST_LANMAN) + else if (CIFSSEC_MUST_LANMAN && + (*flags & CIFSSEC_MUST_LANMAN) == CIFSSEC_MUST_LANMAN) *flags = CIFSSEC_MUST_LANMAN; - else if ((*flags & CIFSSEC_MUST_PLNTXT) == CIFSSEC_MUST_PLNTXT) + else if (CIFSSEC_MUST_PLNTXT && + (*flags & CIFSSEC_MUST_PLNTXT) == CIFSSEC_MUST_PLNTXT) *flags = CIFSSEC_MUST_PLNTXT; *flags |= signflags; |