diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-11-12 12:43:38 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2015-11-13 16:49:35 -0500 |
| commit | d8a080c3746c0b60905a88ca56e83a8239c184e0 (patch) | |
| tree | 37fde95d5504c3cdbfd4e647ba45e15c32887ebe | |
| parent | 78b7b80cf0abd5ea31d229300b11e9c3a97324ae (diff) | |
| download | linux-d8a080c3746c0b60905a88ca56e83a8239c184e0.tar.gz linux-d8a080c3746c0b60905a88ca56e83a8239c184e0.tar.bz2 linux-d8a080c3746c0b60905a88ca56e83a8239c184e0.zip | |
hpsa: logical vs bitwise AND typo
HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
intended here instead of logical &&. This bug is essentially harmless,
it means that sometimes we don't print a warning message which we wanted
to print.
Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/hpsa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6d4412359d23..bff95090e52a 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -8679,7 +8679,7 @@ static void hpsa_disable_rld_caching(struct ctlr_info *h) if ((rc != 0) || (c->err_info->CommandStatus != 0)) goto errout; - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING) + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING) goto out; errout: |