summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-02-04 21:32:27 +0100
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2015-03-25 16:53:27 +1100
commit4b7d8358819da84b1272cdae29ace4680254a104 (patch)
tree0eeffb6d73781a34b81415d355d138950576cfd5
parent3bf57561d4dbd36ba45ce05656b0469bfdcc7ef2 (diff)
downloadlinux-4b7d8358819da84b1272cdae29ace4680254a104.tar.gz
linux-4b7d8358819da84b1272cdae29ace4680254a104.tar.bz2
linux-4b7d8358819da84b1272cdae29ace4680254a104.zip
drivers/macintosh: Delete an unnecessary check before the function call "of_node_put"
The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r--drivers/macintosh/smu.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
index 10ae69bcbbd2..d531f804455d 100644
--- a/drivers/macintosh/smu.c
+++ b/drivers/macintosh/smu.c
@@ -557,8 +557,7 @@ int __init smu_init (void)
return 0;
fail_msg_node:
- if (smu->msg_node)
- of_node_put(smu->msg_node);
+ of_node_put(smu->msg_node);
fail_db_node:
of_node_put(smu->db_node);
fail_bootmem: