diff options
| author | Jason Wang <jasowang@redhat.com> | 2019-02-19 14:53:44 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-02-19 13:14:45 -0800 |
| commit | 816db7663565cd23f74ed3d5c9240522e3fb0dda (patch) | |
| tree | c44fa4c748a27f6898a07c14a5e6afa936e7f223 | |
| parent | 5cd856a5ef9aa189df757c322be34ad735a5b17f (diff) | |
| download | linux-816db7663565cd23f74ed3d5c9240522e3fb0dda.tar.gz linux-816db7663565cd23f74ed3d5c9240522e3fb0dda.tar.bz2 linux-816db7663565cd23f74ed3d5c9240522e3fb0dda.zip | |
vhost: correctly check the return value of translate_desc() in log_used()
When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.
Detected by CoverityScan, CID# 1442593: Control flow issues (DEADCODE)
Fixes: cc5e71075947 ("vhost: log dirty page correctly")
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/vhost/vhost.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 24a129fcdd61..a2e5dc7716e2 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -1788,7 +1788,7 @@ static int log_used(struct vhost_virtqueue *vq, u64 used_offset, u64 len) ret = translate_desc(vq, (uintptr_t)vq->used + used_offset, len, iov, 64, VHOST_ACCESS_WO); - if (ret) + if (ret < 0) return ret; for (i = 0; i < ret; i++) { |