summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2013-02-20 13:16:39 +1100
committerAl Viro <viro@zeniv.linux.org.uk>2013-02-26 02:46:12 -0500
commit9b171e0c74ca0549d0610990a862dd895870f04a (patch)
tree1ec30424bb79be880f56a57798b7f3ac39c01fc1
parent30b9c9e6ba289ba3bb67cc292efcc4122ea37ae5 (diff)
downloadlinux-9b171e0c74ca0549d0610990a862dd895870f04a.tar.gz
linux-9b171e0c74ca0549d0610990a862dd895870f04a.tar.bz2
linux-9b171e0c74ca0549d0610990a862dd895870f04a.zip
ocfs2: fix possible use-after-free with AIO
Running AIO is pinning inode in memory using file reference. Once AIO is completed using aio_complete(), file reference is put and inode can be freed from memory. So we have to be sure that calling aio_complete() is the last thing we do with the inode. Signed-off-by: Jan Kara <jack@suse.cz> Acked-by: Jeff Moyer <jmoyer@redhat.com> Acked-by: Joel Becker <jlbec@evilplan.org> Cc: Mark Fasheh <mfasheh@suse.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/ocfs2/aops.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
index db1ad26e02a7..50fe28b988c1 100644
--- a/fs/ocfs2/aops.c
+++ b/fs/ocfs2/aops.c
@@ -593,9 +593,9 @@ static void ocfs2_dio_end_io(struct kiocb *iocb,
level = ocfs2_iocb_rw_locked_level(iocb);
ocfs2_rw_unlock(inode, level);
+ inode_dio_done(inode);
if (is_async)
aio_complete(iocb, ret, 0);
- inode_dio_done(inode);
}
/*