diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-02-15 21:21:37 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2013-02-20 08:47:54 +1000 |
| commit | 35f8badc1cf652381fa3f82c1fbea39f4dbe87fd (patch) | |
| tree | c2a9a4df9864daf8647bcab7fa5b469da2034440 | |
| parent | 196e077dc165a307efbd9e7569f81bbdbcf18f65 (diff) | |
| download | linux-35f8badc1cf652381fa3f82c1fbea39f4dbe87fd.tar.gz linux-35f8badc1cf652381fa3f82c1fbea39f4dbe87fd.tar.bz2 linux-35f8badc1cf652381fa3f82c1fbea39f4dbe87fd.zip | |
drm: Don't set the plane->fb to NULL on successfull set_plane
We need to clear the local variable to get the refcounting right
(since the reference drm_mode_setplane holds is transferred to the
plane->fb pointer). But should be done _after_ we update the pointer.
Breakage introduced in
commit 6c2a75325c800de286166c693e0cd33c3a1c5ec8
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Tue Dec 11 00:59:24 2012 +0100
drm: refcounting for sprite framebuffers
Reported-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Rob Clark <rob@ti.com>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/drm_crtc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index f17077307c65..e7471b0880b7 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -1996,9 +1996,9 @@ int drm_mode_setplane(struct drm_device *dev, void *data, plane_req->src_w, plane_req->src_h); if (!ret) { old_fb = plane->fb; - fb = NULL; plane->crtc = crtc; plane->fb = fb; + fb = NULL; } drm_modeset_unlock_all(dev); |