diff options
| author | Boris Ostrovsky <boris.ostrovsky@oracle.com> | 2018-06-21 13:29:44 -0400 |
|---|---|---|
| committer | Juergen Gross <jgross@suse.com> | 2018-06-22 08:32:52 +0200 |
| commit | eef04c7b3786ff0c9cb1019278b6c6c2ea0ad4ff (patch) | |
| tree | 35b7d6abe199f0d62ed0c77b16d6b055a348558a | |
| parent | c51b3c639e01f20559531eef3c5919feae23c55a (diff) | |
| download | linux-eef04c7b3786ff0c9cb1019278b6c6c2ea0ad4ff.tar.gz linux-eef04c7b3786ff0c9cb1019278b6c6c2ea0ad4ff.tar.bz2 linux-eef04c7b3786ff0c9cb1019278b6c6c2ea0ad4ff.zip | |
xen: Remove unnecessary BUG_ON from __unbind_from_irq()
Commit 910f8befdf5b ("xen/pirq: fix error path cleanup when binding
MSIs") fixed a couple of errors in error cleanup path of
xen_bind_pirq_msi_to_irq(). This cleanup allowed a call to
__unbind_from_irq() with an unbound irq, which would result in
triggering the BUG_ON there.
Since there is really no reason for the BUG_ON (xen_free_irq() can
operate on unbound irqs) we can remove it.
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: stable@vger.kernel.org
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
| -rw-r--r-- | drivers/xen/events/events_base.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 762378f1811c..08e4af04d6f2 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -628,8 +628,6 @@ static void __unbind_from_irq(unsigned int irq) xen_irq_info_cleanup(info); } - BUG_ON(info_for_irq(irq)->type == IRQT_UNBOUND); - xen_free_irq(irq); } |