summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHector Palacios <hector.palacios@digi.com>2010-04-29 15:02:28 -0700
committerGrant Likely <grant.likely@secretlab.ca>2010-04-29 16:40:30 -0600
commit95b1ed2ac7ffe3205afc6f5a20320fbdb984da92 (patch)
tree774300dd52221307133f6bf9fd61c398bce8d0e1
parentdda04c7bcf58cb02ac796beb1cf483aa5277f2af (diff)
downloadlinux-95b1ed2ac7ffe3205afc6f5a20320fbdb984da92.tar.gz
linux-95b1ed2ac7ffe3205afc6f5a20320fbdb984da92.tar.bz2
linux-95b1ed2ac7ffe3205afc6f5a20320fbdb984da92.zip
spi: spidev_test gives error upon 1-byte transfer
The sample application spidev_test.c is using SPI_IOC_MESSAGE ioctl to do an SPI transfer. This ioctl returns the number of bytes successfully transmitted or a negative error code upon erroneous completion. The application however is returning an error if the result of the ioclt if the return value is 1. This makes the application to fail upon 1-byte length transfers. Signed-off-by: Hector Palacios <hector.palacios@digi.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
-rw-r--r--Documentation/spi/spidev_test.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/spi/spidev_test.c b/Documentation/spi/spidev_test.c
index 10abd3773e49..16feda901469 100644
--- a/Documentation/spi/spidev_test.c
+++ b/Documentation/spi/spidev_test.c
@@ -58,7 +58,7 @@ static void transfer(int fd)
};
ret = ioctl(fd, SPI_IOC_MESSAGE(1), &tr);
- if (ret == 1)
+ if (ret < 1)
pabort("can't send spi message");
for (ret = 0; ret < ARRAY_SIZE(tx); ret++) {