diff options
| author | Jeff Layton <jlayton@kernel.org> | 2019-04-24 10:05:39 -0400 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2019-05-07 19:22:38 +0200 |
| commit | 488f5284e29b2dbb7c224d51b56fc20348e73735 (patch) | |
| tree | 78d4778770179e78350624efff6841ff5dd41d0e | |
| parent | 1199d7da2d29dac5e3983ea1078dbd4ab107e33f (diff) | |
| download | linux-488f5284e29b2dbb7c224d51b56fc20348e73735.tar.gz linux-488f5284e29b2dbb7c224d51b56fc20348e73735.tar.bz2 linux-488f5284e29b2dbb7c224d51b56fc20348e73735.zip | |
ceph: just call get_session in __ceph_lookup_mds_session
I originally thought there was a potential race here, but the fact
that this is called with the mdsc->mutex held, ensures that the
last reference to the session can't be put here.
Still, it's clearer to just return the value from get_session here,
and may prevent a bug later if we ever rework this code to be less
reliant on mutexes.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
| -rw-r--r-- | fs/ceph/mds_client.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 0026ca094e22..5f3f375cf0e9 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -550,15 +550,9 @@ void ceph_put_mds_session(struct ceph_mds_session *s) struct ceph_mds_session *__ceph_lookup_mds_session(struct ceph_mds_client *mdsc, int mds) { - struct ceph_mds_session *session; - if (mds >= mdsc->max_sessions || !mdsc->sessions[mds]) return NULL; - session = mdsc->sessions[mds]; - dout("lookup_mds_session %p %d\n", session, - refcount_read(&session->s_ref)); - get_session(session); - return session; + return get_session(mdsc->sessions[mds]); } static bool __have_session(struct ceph_mds_client *mdsc, int mds) |