diff options
| author | Johan Hovold <johan@kernel.org> | 2017-05-11 11:41:20 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2017-05-15 11:51:15 +0200 |
| commit | 26cede343656c0bc2c33cdc783771282405c7fb2 (patch) | |
| tree | a3f6d25d62b373a84fc8fdf1cc76cdac27ad8c73 | |
| parent | ad0ccac76dcc92c3331f4c94c9fc54f8bf1ab20c (diff) | |
| download | linux-26cede343656c0bc2c33cdc783771282405c7fb2.tar.gz linux-26cede343656c0bc2c33cdc783771282405c7fb2.tar.bz2 linux-26cede343656c0bc2c33cdc783771282405c7fb2.zip | |
USB: serial: mct_u232: fix big-endian baud-rate handling
Drop erroneous cpu_to_le32 when setting the baud rate, something which
corrupted the divisor on big-endian hosts.
Found using sparse:
warning: incorrect type in argument 1 (different base types)
expected unsigned int [unsigned] [usertype] val
got restricted __le32 [usertype] <noident>
Fixes: af2ac1a091bc ("USB: serial mct_usb232: move DMA buffers to heap")
Cc: stable <stable@vger.kernel.org> # 2.6.34
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-By: Pete Zaitcev <zaitcev@yahoo.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/mct_u232.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c index edbc81f205c2..70f346f1aa86 100644 --- a/drivers/usb/serial/mct_u232.c +++ b/drivers/usb/serial/mct_u232.c @@ -189,7 +189,7 @@ static int mct_u232_set_baud_rate(struct tty_struct *tty, return -ENOMEM; divisor = mct_u232_calculate_baud_rate(serial, value, &speed); - put_unaligned_le32(cpu_to_le32(divisor), buf); + put_unaligned_le32(divisor, buf); rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), MCT_U232_SET_BAUD_RATE_REQUEST, MCT_U232_SET_REQUEST_TYPE, |