diff options
| author | Alexander Aring <aahringo@redhat.com> | 2021-05-31 17:00:30 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-06-01 15:18:49 -0700 |
| commit | dd9082f4a9f94280fbbece641bf8fc0a25f71f7a (patch) | |
| tree | c56efd77a351e60ba89dde14070454673b192d2f | |
| parent | 4ef8d857b5f494e62bce9085031563fda35f9563 (diff) | |
| download | linux-dd9082f4a9f94280fbbece641bf8fc0a25f71f7a.tar.gz linux-dd9082f4a9f94280fbbece641bf8fc0a25f71f7a.tar.bz2 linux-dd9082f4a9f94280fbbece641bf8fc0a25f71f7a.zip | |
net: sock: fix in-kernel mark setting
This patch fixes the in-kernel mark setting by doing an additional
sk_dst_reset() which was introduced by commit 50254256f382 ("sock: Reset
dst when changing sk_mark via setsockopt"). The code is now shared to
avoid any further suprises when changing the socket mark value.
Fixes: 84d1c617402e ("net: sock: add sock_set_mark")
Reported-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/sock.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/net/core/sock.c b/net/core/sock.c index 958614ea16ed..946888afef88 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -815,10 +815,18 @@ void sock_set_rcvbuf(struct sock *sk, int val) } EXPORT_SYMBOL(sock_set_rcvbuf); +static void __sock_set_mark(struct sock *sk, u32 val) +{ + if (val != sk->sk_mark) { + sk->sk_mark = val; + sk_dst_reset(sk); + } +} + void sock_set_mark(struct sock *sk, u32 val) { lock_sock(sk); - sk->sk_mark = val; + __sock_set_mark(sk, val); release_sock(sk); } EXPORT_SYMBOL(sock_set_mark); @@ -1126,10 +1134,10 @@ set_sndbuf: case SO_MARK: if (!ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)) { ret = -EPERM; - } else if (val != sk->sk_mark) { - sk->sk_mark = val; - sk_dst_reset(sk); + break; } + + __sock_set_mark(sk, val); break; case SO_RXQ_OVFL: |