diff options
| author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2020-09-25 10:55:18 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-09-25 14:41:50 +0200 |
| commit | f97769fde678e111a1b7b165b380d8a3dfe54f4e (patch) | |
| tree | f9866b19caa352f61ed1889a898e5d6345594bb0 | |
| parent | 5a487cf7efe4b63e902d6883b17b8f505db21ab0 (diff) | |
| download | linux-f97769fde678e111a1b7b165b380d8a3dfe54f4e.tar.gz linux-f97769fde678e111a1b7b165b380d8a3dfe54f4e.tar.bz2 linux-f97769fde678e111a1b7b165b380d8a3dfe54f4e.zip | |
slimbus: core: check get_addr before removing laddr ida
logical address can be either assigned by the SLIMBus controller or the core.
Core uses IDA in cases where get_addr callback is not provided by the
controller.
Core already has this check while allocating IDR, however during absence
reporting this is not checked. This patch fixes this issue.
Fixes: 46a2bb5a7f7e ("slimbus: core: Add slim controllers support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200925095520.27316-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/slimbus/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index ae1e248a8fb8..58b63ae0e75a 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -326,8 +326,8 @@ void slim_report_absent(struct slim_device *sbdev) mutex_lock(&ctrl->lock); sbdev->is_laddr_valid = false; mutex_unlock(&ctrl->lock); - - ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr); + if (!ctrl->get_laddr) + ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr); slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_DOWN); } EXPORT_SYMBOL_GPL(slim_report_absent); |