diff options
| author | Richard Fitzgerald <rf@opensource.cirrus.com> | 2021-05-11 14:28:55 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-05-11 16:01:29 +0100 |
| commit | 0fad605fb0bdc00d8ad78696300ff2fbdee6e048 (patch) | |
| tree | 59ac0a19722be5431a0505a883205820e7cb1e43 | |
| parent | f0353e1f53f92f7b3da91e6669f5d58ee222ebe8 (diff) | |
| download | linux-0fad605fb0bdc00d8ad78696300ff2fbdee6e048.tar.gz linux-0fad605fb0bdc00d8ad78696300ff2fbdee6e048.tar.bz2 linux-0fad605fb0bdc00d8ad78696300ff2fbdee6e048.zip | |
ASoC: cs42l42: Regmap must use_single_read/write
cs42l42 does not support standard burst transfers so the use_single_read
and use_single_write flags must be set in the regmap config.
Because of this bug, the patch:
commit 0a0eb567e1d4 ("ASoC: cs42l42: Minor error paths fixups")
broke cs42l42 probe() because without the use_single_* flags it causes
regmap to issue a burst read.
However, the missing use_single_* could cause problems anyway because the
regmap cache can attempt burst transfers if these flags are not set.
Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210511132855.27159-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/cs42l42.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index bf982e145e94..77473c226f9e 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -399,6 +399,9 @@ static const struct regmap_config cs42l42_regmap = { .reg_defaults = cs42l42_reg_defaults, .num_reg_defaults = ARRAY_SIZE(cs42l42_reg_defaults), .cache_type = REGCACHE_RBTREE, + + .use_single_read = true, + .use_single_write = true, }; static DECLARE_TLV_DB_SCALE(adc_tlv, -9600, 100, false); |