diff options
| author | Lin Yi <teroincn@163.com> | 2019-05-10 12:22:57 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-24 10:09:12 +0200 |
| commit | 8c8af41d24c73c6a8b24468bdc53e52b390e4582 (patch) | |
| tree | f9c4a80b6ad98d5a86d2c9c39deeb60bafa2773b | |
| parent | 5e309c6c5ea12515616a4835b7fa2141c8016c94 (diff) | |
| download | linux-8c8af41d24c73c6a8b24468bdc53e52b390e4582.tar.gz linux-8c8af41d24c73c6a8b24468bdc53e52b390e4582.tar.bz2 linux-8c8af41d24c73c6a8b24468bdc53e52b390e4582.zip | |
tty: tty_io: fix driver refcount imbalance on error path
tty_lookup_driver take a reference to the struct tty_driver, but forget
to release it on the error path, lead to a memory leak.
add a tty_driver_kref_put before error return.
Signed-off-by: Lin Yi <teroincn@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/tty_io.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 033ac7e6a70d..566728fbaf3c 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -1837,7 +1837,7 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp) static struct tty_driver *tty_lookup_driver(dev_t device, struct file *filp, int *index) { - struct tty_driver *driver; + struct tty_driver *driver = NULL; switch (device) { #ifdef CONFIG_VT @@ -1858,6 +1858,8 @@ static struct tty_driver *tty_lookup_driver(dev_t device, struct file *filp, break; } } + if (driver) + tty_driver_kref_put(driver); return ERR_PTR(-ENODEV); } default: |