diff options
| author | Eric Biggers <ebiggers@google.com> | 2017-11-05 18:30:48 -0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2017-11-10 19:20:22 +0800 |
| commit | ced6a58638432c9f731184f908208d539725ba82 (patch) | |
| tree | e723e433ade388f6d6cb4e79b450f35d64aa5a5b | |
| parent | 5829cc8da94f500b0c1fe82688d89fd36a1a9a41 (diff) | |
| download | linux-ced6a58638432c9f731184f908208d539725ba82.tar.gz linux-ced6a58638432c9f731184f908208d539725ba82.tar.bz2 linux-ced6a58638432c9f731184f908208d539725ba82.zip | |
crypto: dh - Remove pointless checks for NULL 'p' and 'g'
Neither 'p' nor 'g' can be NULL, as they were unpacked using
crypto_dh_decode_key(). And it makes no sense for them to be optional.
So remove the NULL checks that were copy-and-pasted into both modules.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | crypto/dh.c | 3 | ||||
| -rw-r--r-- | drivers/crypto/qat/qat_common/qat_asym_algs.c | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/crypto/dh.c b/crypto/dh.c index aadaf36fb56f..5659fe7f446d 100644 --- a/crypto/dh.c +++ b/crypto/dh.c @@ -53,9 +53,6 @@ static int dh_check_params_length(unsigned int p_len) static int dh_set_params(struct dh_ctx *ctx, struct dh *params) { - if (unlikely(!params->p || !params->g)) - return -EINVAL; - if (dh_check_params_length(params->p_size << 3)) return -EINVAL; diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c index 7655fdb499de..13c52d6bf630 100644 --- a/drivers/crypto/qat/qat_common/qat_asym_algs.c +++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c @@ -443,9 +443,6 @@ static int qat_dh_set_params(struct qat_dh_ctx *ctx, struct dh *params) struct qat_crypto_instance *inst = ctx->inst; struct device *dev = &GET_DEV(inst->accel_dev); - if (unlikely(!params->p || !params->g)) - return -EINVAL; - if (qat_dh_check_params_length(params->p_size << 3)) return -EINVAL; |