summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJens Axboe <axboe@fb.com>2014-09-19 08:04:53 -0600
committerJens Axboe <axboe@fb.com>2014-09-22 11:55:23 -0600
commit6b55e1f2d0a5e462e52678278ab749468f1db81c (patch)
tree8d5c5d578cba71e51d11f2231f5528d0aa9dd7e0
parenta57a178a490345c7236b0077b3de005754389ed6 (diff)
downloadlinux-6b55e1f2d0a5e462e52678278ab749468f1db81c.tar.gz
linux-6b55e1f2d0a5e462e52678278ab749468f1db81c.tar.bz2
linux-6b55e1f2d0a5e462e52678278ab749468f1db81c.zip
blk-mq: fix potential oops on out-of-memory in __blk_mq_alloc_rq_maps()
__blk_mq_alloc_rq_maps() can be invoked multiple times, if we scale back the queue depth if we are low on memory. So don't clear set->tags when we fail, this is handled directly in the parent function, blk_mq_alloc_tag_set(). Reported-by: Robert Elliott <Elliott@hp.com> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--block/blk-mq.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c
index a7d70a1bbf36..e83d306907da 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1959,7 +1959,6 @@ out_unwind:
while (--i >= 0)
blk_mq_free_rq_map(set, set->tags[i], i);
- set->tags = NULL;
return -ENOMEM;
}