diff options
| author | Neeraj Upadhyay <neeraju@codeaurora.org> | 2021-08-18 12:58:41 +0530 |
|---|---|---|
| committer | Paul E. McKenney <paulmck@kernel.org> | 2021-09-15 11:41:14 -0700 |
| commit | d39ec8f3c12abe3710f7031ce3d5564bda12b19e (patch) | |
| tree | 95f5ecff4901afdc471e052d06e2ebacaab2f859 | |
| parent | 89401176daf0a44ab517d9a0e296adb85af246df (diff) | |
| download | linux-d39ec8f3c12abe3710f7031ce3d5564bda12b19e.tar.gz linux-d39ec8f3c12abe3710f7031ce3d5564bda12b19e.tar.bz2 linux-d39ec8f3c12abe3710f7031ce3d5564bda12b19e.zip | |
rcu-tasks: Correct comparisons for CPU numbers in show_stalled_task_trace
Valid CPU numbers can be zero or greater, but the checks for
->trc_ipi_to_cpu and tick_nohz_full_cpu()'s argument are for strictly
greater than. This commit therefore corrects the check for no_hz_full
cpu in show_stalled_task_trace() so as to include cpu 0.
Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
| -rw-r--r-- | kernel/rcu/tasks.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index e2ec548fc0c4..af7388849bed 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -1084,9 +1084,9 @@ static void show_stalled_task_trace(struct task_struct *t, bool *firstreport) cpu = task_cpu(t); pr_alert("P%d: %c%c%c nesting: %d%c cpu: %d\n", t->pid, - ".I"[READ_ONCE(t->trc_ipi_to_cpu) > 0], + ".I"[READ_ONCE(t->trc_ipi_to_cpu) >= 0], ".i"[is_idle_task(t)], - ".N"[cpu > 0 && tick_nohz_full_cpu(cpu)], + ".N"[cpu >= 0 && tick_nohz_full_cpu(cpu)], READ_ONCE(t->trc_reader_nesting), " N"[!!READ_ONCE(t->trc_reader_special.b.need_qs)], cpu); |