diff options
| author | Aditya Pakki <pakki001@umn.edu> | 2019-03-25 16:55:27 -0500 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2019-03-27 10:08:55 -0700 |
| commit | 486fa92df4707b5df58d6508728bdb9321a59766 (patch) | |
| tree | 866f674f33e865b0ce8e199890a10efe4f1e563e | |
| parent | 55c1fc0af29a6c1b92f217b7eb7581a882e0c07c (diff) | |
| download | linux-486fa92df4707b5df58d6508728bdb9321a59766.tar.gz linux-486fa92df4707b5df58d6508728bdb9321a59766.tar.bz2 linux-486fa92df4707b5df58d6508728bdb9321a59766.zip | |
libnvdimm/btt: Fix a kmemdup failure check
In case kmemdup fails, the fix releases resources and returns to
avoid the NULL pointer dereference.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
| -rw-r--r-- | drivers/nvdimm/btt_devs.c | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/drivers/nvdimm/btt_devs.c b/drivers/nvdimm/btt_devs.c index b72a303176c7..9486acc08402 100644 --- a/drivers/nvdimm/btt_devs.c +++ b/drivers/nvdimm/btt_devs.c @@ -198,14 +198,15 @@ static struct device *__nd_btt_create(struct nd_region *nd_region, return NULL; nd_btt->id = ida_simple_get(&nd_region->btt_ida, 0, 0, GFP_KERNEL); - if (nd_btt->id < 0) { - kfree(nd_btt); - return NULL; - } + if (nd_btt->id < 0) + goto out_nd_btt; nd_btt->lbasize = lbasize; - if (uuid) + if (uuid) { uuid = kmemdup(uuid, 16, GFP_KERNEL); + if (!uuid) + goto out_put_id; + } nd_btt->uuid = uuid; dev = &nd_btt->dev; dev_set_name(dev, "btt%d.%d", nd_region->id, nd_btt->id); @@ -220,6 +221,13 @@ static struct device *__nd_btt_create(struct nd_region *nd_region, return NULL; } return dev; + +out_put_id: + ida_simple_remove(&nd_region->btt_ida, nd_btt->id); + +out_nd_btt: + kfree(nd_btt); + return NULL; } struct device *nd_btt_create(struct nd_region *nd_region) |