diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-09-21 15:33:42 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2015-09-21 22:57:37 +0800 |
| commit | 09185e2756a83763bcbfe51b308b85979f0de027 (patch) | |
| tree | 64e960c9c807711bdbd5c5744c617296ad37d408 | |
| parent | 17762c5acee2f1f065291d2a74ebea4d0168063b (diff) | |
| download | linux-09185e2756a83763bcbfe51b308b85979f0de027.tar.gz linux-09185e2756a83763bcbfe51b308b85979f0de027.tar.bz2 linux-09185e2756a83763bcbfe51b308b85979f0de027.zip | |
hwrng: xgene - fix handling platform_get_irq
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | drivers/char/hw_random/xgene-rng.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c index c37cf754a985..3c77645405e5 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -344,11 +344,12 @@ static int xgene_rng_probe(struct platform_device *pdev) if (IS_ERR(ctx->csr_base)) return PTR_ERR(ctx->csr_base); - ctx->irq = platform_get_irq(pdev, 0); - if (ctx->irq < 0) { + rc = platform_get_irq(pdev, 0); + if (rc < 0) { dev_err(&pdev->dev, "No IRQ resource\n"); - return ctx->irq; + return rc; } + ctx->irq = rc; dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d", ctx->csr_base, ctx->irq); |