summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-11-07 10:56:51 +0300
committerLinus Walleij <linus.walleij@linaro.org>2013-11-25 09:03:12 +0100
commit0c8aab8e65e450f2bfea494c1b6a86ded653f88c (patch)
treebd7314e11861b64c017800ce8f8269b86762ca8b
parentbfea603bc54c0a736d45bc60b188a8cdae9aaaa3 (diff)
downloadlinux-0c8aab8e65e450f2bfea494c1b6a86ded653f88c.tar.gz
linux-0c8aab8e65e450f2bfea494c1b6a86ded653f88c.tar.bz2
linux-0c8aab8e65e450f2bfea494c1b6a86ded653f88c.zip
gpio: rcar: NULL dereference on error in probe()
It's not obvious from the label name but "err1" tries to release "p->irq_domain" which leads to a NULL dereference. Fixes: 119f5e448d32 ('gpio: Renesas R-Car GPIO driver V3') Cc: stable@vger.kernel.org Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Magnus Damm <damm@opensource.se> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/gpio/gpio-rcar.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index d3f15ae93bd3..fe088a30567a 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -381,7 +381,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
if (!p->irq_domain) {
ret = -ENXIO;
dev_err(&pdev->dev, "cannot initialize irq domain\n");
- goto err1;
+ goto err0;
}
if (devm_request_irq(&pdev->dev, irq->start,