summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-05-17 22:58:50 +0100
committerVinod Koul <vinod.koul@intel.com>2017-05-19 08:56:16 +0530
commit1fc63cb4f1de790019d57ccaf3e9cd2e6abbc648 (patch)
treec8173b0040cf5c0c9a787b9fb137c76e9d4d9bf6
parent58d96125103c77686271f515d2ffad0d6d0dedc8 (diff)
downloadlinux-1fc63cb4f1de790019d57ccaf3e9cd2e6abbc648.tar.gz
linux-1fc63cb4f1de790019d57ccaf3e9cd2e6abbc648.tar.bz2
linux-1fc63cb4f1de790019d57ccaf3e9cd2e6abbc648.zip
dmaengine: bcm-scm-raid: remove redundant null check on req
Req is never null on at the point of the null check, so remove this redundant check and just return &req->tx. Detected by CoverityScan, CID#1436147 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
-rw-r--r--drivers/dma/bcm-sba-raid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index d6b927b960ab..e41bbc7cb094 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -582,7 +582,7 @@ sba_prep_dma_interrupt(struct dma_chan *dchan, unsigned long flags)
req->tx.flags = flags;
req->tx.cookie = -EBUSY;
- return (req) ? &req->tx : NULL;
+ return &req->tx;
}
static void sba_fillup_memcpy_msg(struct sba_request *req,