summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNathan Chancellor <natechancellor@gmail.com>2018-09-21 12:30:34 -0700
committerDavid S. Miller <davem@davemloft.net>2018-09-21 19:48:36 -0700
commit5b9b0a80aa1aefecb0273563652fb373288a21cb (patch)
treeab8b64e22688d42e88e4d3d5b093ab8af36cdb9b
parentbccc17118bcf3c62c947361d51760334f6602f43 (diff)
downloadlinux-5b9b0a80aa1aefecb0273563652fb373288a21cb.tar.gz
linux-5b9b0a80aa1aefecb0273563652fb373288a21cb.tar.bz2
linux-5b9b0a80aa1aefecb0273563652fb373288a21cb.zip
decnet: Remove unnecessary check for dev->name
Clang warns that the address of a pointer will always evaluated as true in a boolean context. net/decnet/dn_dev.c:1366:10: warning: address of array 'dev->name' will always evaluate to 'true' [-Wpointer-bool-conversion] dev->name ? dev->name : "???", ~~~~~^~~~ ~ 1 warning generated. Link: https://github.com/ClangBuiltLinux/linux/issues/116 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/decnet/dn_dev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
index bfd43e8f2c06..d0b3e69c6b39 100644
--- a/net/decnet/dn_dev.c
+++ b/net/decnet/dn_dev.c
@@ -1363,7 +1363,7 @@ static int dn_dev_seq_show(struct seq_file *seq, void *v)
seq_printf(seq, "%-8s %1s %04u %04u %04lu %04lu"
" %04hu %03d %02x %-10s %-7s %-7s\n",
- dev->name ? dev->name : "???",
+ dev->name,
dn_type2asc(dn_db->parms.mode),
0, 0,
dn_db->t3, dn_db->parms.t3,