diff options
| author | Jon Cooper <jcooper@solarflare.com> | 2014-10-21 14:50:29 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-10-22 12:51:16 -0400 |
| commit | 8fc963515e893867330dec87464e9edc5204c024 (patch) | |
| tree | d9e593f193df9b5eecc46a99cb313f3aa70d3872 | |
| parent | 7c1c97d54f9bfc810908d3903cb8bcacf734df18 (diff) | |
| download | linux-8fc963515e893867330dec87464e9edc5204c024.tar.gz linux-8fc963515e893867330dec87464e9edc5204c024.tar.bz2 linux-8fc963515e893867330dec87464e9edc5204c024.zip | |
sfc: remove incorrect EFX_BUG_ON_PARANOID check
write_count and insert_count can wrap around, making > check invalid.
Fixes: 70b33fb0ddec827cbbd14cdc664fc27b2ef4a6b6 ("sfc: add support for
skb->xmit_more").
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/sfc/tx.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c index ee84a90e371c..aaf2987512b5 100644 --- a/drivers/net/ethernet/sfc/tx.c +++ b/drivers/net/ethernet/sfc/tx.c @@ -343,8 +343,6 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb) unsigned short dma_flags; int i = 0; - EFX_BUG_ON_PARANOID(tx_queue->write_count > tx_queue->insert_count); - if (skb_shinfo(skb)->gso_size) return efx_enqueue_skb_tso(tx_queue, skb); @@ -1258,8 +1256,6 @@ static int efx_enqueue_skb_tso(struct efx_tx_queue *tx_queue, /* Find the packet protocol and sanity-check it */ state.protocol = efx_tso_check_protocol(skb); - EFX_BUG_ON_PARANOID(tx_queue->write_count > tx_queue->insert_count); - rc = tso_start(&state, efx, skb); if (rc) goto mem_err; |