diff options
| author | Kees Cook <keescook@chromium.org> | 2017-05-05 15:25:32 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-08 14:41:41 -0400 |
| commit | 9e4eb1ce472fbf7b007f23c88ec11c37265e401c (patch) | |
| tree | c98e366cdbadd084541b6722371b68af37a9d4f6 | |
| parent | 8403debeead8e8b296d7a7db2174af524695ab42 (diff) | |
| download | linux-9e4eb1ce472fbf7b007f23c88ec11c37265e401c.tar.gz linux-9e4eb1ce472fbf7b007f23c88ec11c37265e401c.tar.bz2 linux-9e4eb1ce472fbf7b007f23c88ec11c37265e401c.zip | |
bna: Avoid reading past end of buffer
Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.
This was found with the future CONFIG_FORTIFY_SOURCE feature.
Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/brocade/bna/bfa_ioc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index 0f6811860ad5..a36e38676640 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -2845,7 +2845,7 @@ bfa_ioc_get_adapter_optrom_ver(struct bfa_ioc *ioc, char *optrom_ver) static void bfa_ioc_get_adapter_manufacturer(struct bfa_ioc *ioc, char *manufacturer) { - memcpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN); + strncpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN); } static void |