summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2012-08-16 20:25:59 -0700
committerMark Brown <broonie@opensource.wolfsonmicro.com>2012-08-17 22:46:41 +0100
commita0c3652caa357b8f4e76efe401646ef298483cd9 (patch)
tree73f94a36f9c754ad9102bcf818cc8373881a15cc
parent6887237cd7da904184dab2750504040c68f3a080 (diff)
downloadlinux-a0c3652caa357b8f4e76efe401646ef298483cd9.tar.gz
linux-a0c3652caa357b8f4e76efe401646ef298483cd9.tar.bz2
linux-a0c3652caa357b8f4e76efe401646ef298483cd9.zip
spi: spi-coldfire-qspi: Drop extra spi_master_put in device remove function
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which and results in device memory being freed. The subsequent call to spi_master_put is unnecessary and results in an access to free memory. Drop it. Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r--drivers/spi/spi-coldfire-qspi.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c
index b2d4b9e4e010..1a30b47465cb 100644
--- a/drivers/spi/spi-coldfire-qspi.c
+++ b/drivers/spi/spi-coldfire-qspi.c
@@ -533,7 +533,6 @@ static int __devexit mcfqspi_remove(struct platform_device *pdev)
iounmap(mcfqspi->iobase);
release_mem_region(res->start, resource_size(res));
spi_unregister_master(master);
- spi_master_put(master);
return 0;
}