diff options
| author | Tobias Klauser <tklauser@distanz.ch> | 2015-11-18 10:48:16 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-11-24 15:25:46 -0800 |
| commit | e8c77bda05e5d93cce6f38cfdde4192307951dea (patch) | |
| tree | 966ff193f3eb29d69dc31face6da2f37c4191c3e | |
| parent | 07687c031d14a1f36613231c0ea13ce3c4025615 (diff) | |
| download | linux-e8c77bda05e5d93cce6f38cfdde4192307951dea.tar.gz linux-e8c77bda05e5d93cce6f38cfdde4192307951dea.tar.bz2 linux-e8c77bda05e5d93cce6f38cfdde4192307951dea.zip | |
fpga manager: Fix firmware resource leak on error
If fpga_mgr_buf_load() fails, the firmware resource previously allocated
by request_firmware() is leaked. Fix it by calling release_firmware()
regardless of the return value of fpga_mgr_buf_load().
Found by the Coverity scanner (CID 1339653).
Fixes: 6a8c3be7ec8e ("add FPGA manager core")
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Alan Tull <atull@opensource.altera.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/fpga/fpga-mgr.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index bfbf8aa2de04..953dc9195937 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -122,12 +122,10 @@ int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags, } ret = fpga_mgr_buf_load(mgr, flags, fw->data, fw->size); - if (ret) - return ret; release_firmware(fw); - return 0; + return ret; } EXPORT_SYMBOL_GPL(fpga_mgr_firmware_load); |