diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2018-04-22 18:23:47 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2018-04-24 19:50:05 -0700 |
| commit | eb366989aa42e688b525929a0ff67ac047df7ee3 (patch) | |
| tree | fa6af5069b4b4388c1178663f23f97c34decc38d | |
| parent | 83a530e1610ab996e59c0941db6cc72f763dddbd (diff) | |
| download | linux-eb366989aa42e688b525929a0ff67ac047df7ee3.tar.gz linux-eb366989aa42e688b525929a0ff67ac047df7ee3.tar.bz2 linux-eb366989aa42e688b525929a0ff67ac047df7ee3.zip | |
dm/verity_fec: Use GFP aware reed solomon init
Allocations from the rs_pool can invoke init_rs() from the mempool
allocation callback. This is problematic in fec_alloc_bufs() which invokes
mempool_alloc() with GFP_NOIO to prevent a swap deadlock because init_rs()
uses GFP_KERNEL allocations.
Switch it to init_rs_gfp() and invoke it with the gfp_t flags which are
handed in from the allocator.
Note: This is not a problem today because the rs control struct is shared
between the instances and its created when the mempool is initialized. But
the upcoming changes which switch to a rs_control struct per instance to
embed decoder buffers will trigger the swap vs. GFP_KERNEL issue.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Neil Brown <neilb@suse.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
| -rw-r--r-- | drivers/md/dm-verity-fec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-verity-fec.c b/drivers/md/dm-verity-fec.c index e13f90832b6b..375453ef6f26 100644 --- a/drivers/md/dm-verity-fec.c +++ b/drivers/md/dm-verity-fec.c @@ -570,7 +570,7 @@ static void *fec_rs_alloc(gfp_t gfp_mask, void *pool_data) { struct dm_verity *v = (struct dm_verity *)pool_data; - return init_rs(8, 0x11d, 0, 1, v->fec->roots); + return init_rs_gfp(8, 0x11d, 0, 1, v->fec->roots, gfp_mask); } static void fec_rs_free(void *element, void *pool_data) |