diff options
| author | Robert P. J. Day <rpjday@crashcourse.ca> | 2009-05-12 13:43:36 -0700 |
|---|---|---|
| committer | Sam Ravnborg <sam@ravnborg.org> | 2009-06-09 22:37:52 +0200 |
| commit | 1581c1cede3b180b77aa08024c6ca406252cc21f (patch) | |
| tree | 27aaeee0e6a263b221fc402b3a2cbd5122de8919 | |
| parent | ad6ccfad6f759a5d657dabe2071a8f2a503fcc84 (diff) | |
| download | linux-1581c1cede3b180b77aa08024c6ca406252cc21f.tar.gz linux-1581c1cede3b180b77aa08024c6ca406252cc21f.tar.bz2 linux-1581c1cede3b180b77aa08024c6ca406252cc21f.zip | |
scripts/headers_check.pl: correct RE in header CONFIG leak check
Correct the regular expression in scripts/headers_check.pl to include '_'
as a valid character in the class; otherwise, the check will report a
"leaked" symbol of CONFIG_A_B_C as merely CONFIG_A.
This patch will make no difference whatsoever in the current kernel tree
as the call to the perl routine that does that check is currently
commented out:
&check_include();
&check_asm_types();
&check_sizetypes();
&check_prototypes();
# Dropped for now. Too much noise &check_config();
However, I noticed that problem when I was building the yum downloadable
kernel source rpm for fedora 11 (beta), which *does* run that check, and
that's where the problem became obvious.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
| -rw-r--r-- | scripts/headers_check.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 56f90a480899..4414c43857ad 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -70,7 +70,7 @@ sub check_prototypes sub check_config { - if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9]+)[^a-zA-Z0-9]/) { + if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9_]+)[^a-zA-Z0-9_]/) { printf STDERR "$filename:$lineno: leaks CONFIG_$1 to userspace where it is not valid\n"; } } |